Turn Off Logging?

CheesePizza · July 23, 2015, 5:25pm

Is there a way to turn off logging that Hangfire does? We are using our own abstraction on top of log4Net and I don’t want all this extra noise coming from the Hangfire logger.

yngndrw · July 24, 2015, 10:45am

There is already a NoOpLogger which requires null to be passed in as the log provider:
http://docs.hangfire.io/en/latest/configuration/configuring-logging.html

github.com

HangfireIO/Hangfire/blob/5a770aab402b820f262f0872b18c2d3304bb7128/src/Hangfire.Core/App_Packages/LibLog.1.4/LibLog.cs#L415


        catch (Exception ex)
        {
            Console.WriteLine(
                "Exception occured resolving a log provider. Logging for this assembly {0} is disabled. {1}",
                typeof(LogProvider).Assembly.FullName,
                ex);
        }
        return null;
    }


    public class NoOpLogger : ILog
    {
        public bool Log(LogLevel logLevel, Func<string> messageFunc, Exception exception)
        {
            return false;
        }
    }
}


public class LoggerExecutionWrapper : ILog
{

github.com

HangfireIO/Hangfire/blob/5a770aab402b820f262f0872b18c2d3304bb7128/src/Hangfire.Core/App_Packages/LibLog.1.4/LibLog.cs#L366


}


/// <summary>
/// Gets a logger with the specified name.
/// </summary>
/// <param name="name">The name.</param>
/// <returns>An instance of <see cref="ILog"/></returns>
public static ILog GetLogger(string name)
{
    ILogProvider logProvider = _currentLogProvider ?? ResolveLogProvider();
    return logProvider == null ? new NoOpLogger() : (ILog)new LoggerExecutionWrapper(logProvider.GetLogger(name));
}


/// <summary>
/// Sets the current log provider.
/// </summary>
/// <param name="logProvider">The log provider.</param>
public static void SetCurrentLogProvider(ILogProvider logProvider)
{
    _currentLogProvider = logProvider;
}

I.e:

LogProvider.SetCurrentLogProvider(null);

Please note that you cannot use Hangfire’s configuration extension to do this as it does not allow a null provider:

github.com

HangfireIO/Hangfire/blob/5a770aab402b820f262f0872b18c2d3304bb7128/src/Hangfire.Core/GlobalConfigurationExtensions.cs#L59




    return configuration.Use(activator, x => JobActivator.Current = x);
}


public static IGlobalConfiguration<TLogProvider> UseLogProvider<TLogProvider>(
    [NotNull] this IGlobalConfiguration configuration,
    [NotNull] TLogProvider provider)
    where TLogProvider : ILogProvider
{
    if (configuration == null) throw new ArgumentNullException("configuration");
    if (provider == null) throw new ArgumentNullException("provider");
    
    return configuration.Use(provider, x => LogProvider.SetCurrentLogProvider(x));
}


public static IGlobalConfiguration<NLogLogProvider> UseNLogLogProvider(
    [NotNull] this IGlobalConfiguration configuration)
{
    if (configuration == null) throw new ArgumentNullException("configuration");


    return configuration.UseLogProvider(new NLogLogProvider());

odinserj · July 27, 2015, 10:18am

I think we should allow to pass a null identifier, or (may be this is better?) add a new method UseNoOpLogger or somethink like that. On the other hand, modern logging libraries allow to disable loggers by wildcard Hangfire.*, however it may be difficult to learn how to do that. Guys, what do you think?

yngndrw · July 27, 2015, 10:25am

I think that we should do both, allow null in UseLogProvider as this is a valid input and also add UseNoOpLogger as this matches the rest of the helpers within GlobalConfigurationExtensions. The fluent interface that GlobalConfigurationExtensions provides is quite nice and a UseNoOpLogger method would compliment that.

I wouldn’t rely on a logging provider’s ability to filter as the user may have a non-standard setup.

odinserj · July 27, 2015, 10:33am

However, without logging it will be pretty hard to see what’s wrong with background processing. It is like catching all the exceptions for web request. Nice – no exceptions, no problems. Maybe it is much better to lower the extra noise instead?

@CheesePizza, what logging messages annoyed you?

CheesePizza · July 27, 2015, 2:14pm

Well ideally I wouldn’t want any logging messages to come from Hangfire. Admittedly, our logging solution is a bit overkill. By requirement, we have to interact with a company wide enterprise logger which is a WCF service. But we are working in a Web API solution where we want our own logging. So we are using bits of this enterprise logger to satisfy requirements. Then we have our logging inside our application which is common logging and log4net, and inside our Web API, we are not logging everything.

So even if we change our log4net configuration to say, INFO for example, we would get INFO messages from Hangfire. We are not interested in INFO messages from Hangfire, only things we are explicitly coding for within the application.

Giving users the option to opt in to logging seems like a good approach for those that already having a logging implementation with their application.

odinserj · July 27, 2015, 2:23pm

Even FATAL exception messages that tell you background processing is not working at all? How do you debug your application when abnormal things happen?

haroon · September 8, 2015, 2:33pm

I am interested on how I can bring the noise level down.

How can I only allow FATAL logging to come from hangfire?

I think by default the logging should be FATAL or WARN?

odinserj · September 9, 2015, 9:14am

@haroon, most of the popular logging frameworks allow to configure the minimum log level to log. What framework do you use? Another option – to tune the messages themselves in Hangfire itself. What noise messages do you have?

haroon · September 9, 2015, 8:10pm

@odinserj I currently have nlog set up as:

  <logger name="Hangfire.*" minlevel="Fatal" writeTo="logfile"  />
  <logger name="Awesome.*" minLevel="Trace" appendTo="syslog" enabled="false" />
  <logger name="Awesome.*" minLevel="Trace" appendTo="logfile" />

With this configuration I am still getting Debug and Trace logs in my syslog (papertrail app).

What am I doing wrong? I only want the Fatal errors to appear in my log files.

odinserj · September 10, 2015, 10:12am

@haroon, what version of Hangfire are you using? There is a bug with logger names in 1.5.0 betas, that causes loggers to use ToString method instead of GetType, and, for example, workers have Worker #XXXXX name instead of Hangfire.Server.Worker.

Josh_Goldman · January 27, 2016, 7:10pm

Hi @odinserj,

I am having the same problem. I would like to separate out the Hangfire logging from my regular application logging. I am using Hangfire v1.5.3 and NLog v4.2.3. I have similar logging filters set up as @haroon, but I am still getting logging going on to my sources anyway. The “logger” shows up as “Hangfire.Server.RecurringJobScheduler” or something similar so I would hope that this specifying “Hangfire.*” is not the issue, but something else where Hangfire is bypassing the NLog settings. Please help. Thank you.

Josh_Goldman · January 27, 2016, 8:53pm

Hi again. This may have resolved itself – I didn’t realize that I had to restart the server for the logging to change, but I think now that I have made changes to the nlog.config file and restarted the server, my changes have stuck.

kurre · April 9, 2018, 5:04am

this is really annoying…I have the same problem as the OP and I am unable to get logging working as the Hangfire project references other project that use our logger and I think that HF think that it should then use Log4net…

It does not throw an exception but it does not seem to log either. I’ve tried setting the currentprovider to null and use only our log4net abstractnio but it does not log it anywhere I can see

Topic		Replies	Views
Log4net, howto? question log4net	3	4587	September 7, 2017
Custom Logging of Uncaught Exceptions bug?	3	3173	March 8, 2017
Logging configuration question	0	1365	March 3, 2015
log4Net logging question	3	12425	January 18, 2018
Can not log exceptions question logging	0	229	January 31, 2024

Turn Off Logging?

Related topics